feat: export authorization metadata to user extended data #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentinchampenois
requested changes
Jul 26, 2024
| } | ||
|
|
||
| def export_to_user_extended_data | ||
| Decidim::AuthorizationDataToUserDataService.run(name: name, user: user) |
There was a problem hiding this comment.
We should use another Service or adapt this one because the after_commit hook will fetch all authorizations for a given user and update every time her extended_data column.
In the after_commit hook we should update directly the extended_data column
Example:
Suggested change
| Decidim::AuthorizationDataToUserDataService.run(name: name, user: user) | |
| extended_data = user.extended_data | |
| extended_data.merge!({ name.to_s => authorization.metadata }) | |
| user.extended_data = extended_data | |
| user.save |
There was a problem hiding this comment.
The service is already filtered with the name of the authorization (and it's not possible to have 2 authorizations with the same name and user).
The idea was to avoid duplicate the code if we need to edit the part that handle the data update.
app/services/decidim/authorization_data_to_user_data_service.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Quentin Champenois <26109239+Quentinchampenois@users.noreply.github.com>
Co-authored-by: Quentin Champenois <26109239+Quentinchampenois@users.noreply.github.com>
e8465c5 to
cf2e303
Compare
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage example :
bundle exec rails authorizations:export_to_user_extended_data AUTHORIZATION_HANDLE_NAME=extended_socio_demographic_authorization_handler