Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix survey validation #228

Merged
merged 10 commits into from
Jan 23, 2023
Merged

Fix survey validation #228

merged 10 commits into from
Jan 23, 2023

Conversation

eliegaboriau
Copy link
Contributor

@eliegaboriau eliegaboriau commented Jan 19, 2023 •
edited
Loading

🎩 Description

Please describe your pull request.

This PR modify the survey validation flow :
It now show the entire form when there is an error and scroll back to the first error.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as admin
  • Access Backoffice
  • Go to survey settings
  • Add mandatory text field and separator
  • Go and anwser the survey
  • Don't fill in a mandatory text field
  • Submit and see you are redirected to the entire survey and to the first error
  • fill in the mandatory text field but don't fill in a mandatory field other thant text
  • Submit and see you are again redirected to the entire survey

Tasks

  • Add specs

@eliegaboriau eliegaboriau marked this pull request as ready for review January 20, 2023 13:59
@eliegaboriau eliegaboriau requested review from paulinebessoles, a team and Quentinchampenois and removed request for a team January 20, 2023 13:59
@eliegaboriau eliegaboriau marked this pull request as draft January 20, 2023 14:00
@eliegaboriau eliegaboriau marked this pull request as ready for review January 20, 2023 14:06
paulinebessoles
paulinebessoles previously approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@paulinebessoles paulinebessoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eliegaboriau 👏

@eliegaboriau eliegaboriau changed the base branch from release/0.26-stable to develop January 20, 2023 15:06
@eliegaboriau eliegaboriau dismissed paulinebessoles’s stale review January 20, 2023 15:06

The base branch was changed.

Quentinchampenois
Quentinchampenois requested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, product tests work as expected

I think we should limit overrides and use extends. Also can you add entries of added overrides to the OVERLOADS.md file please ?

app/cells/decidim/forms/step_navigation_cell.rb Outdated Show resolved Hide resolved
app/helpers/decidim/forms/application_helper.rb Outdated Show resolved Hide resolved
moustachu
moustachu previously approved these changes Jan 23, 2023
View reviewed changes
@Quentinchampenois Quentinchampenois merged commit 8f873da into develop Jan 23, 2023
@Quentinchampenois Quentinchampenois deleted the fix_survey_validation branch January 23, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentinchampenois Quentinchampenois Quentinchampenois approved these changes

@paulinebessoles paulinebessoles paulinebessoles left review comments

@moustachu moustachu moustachu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eliegaboriau @moustachu @Quentinchampenois @paulinebessoles