Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check that all proto files are included in build #746

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Add check that all proto files are included in build #746

merged 1 commit into from
Mar 8, 2024

Conversation

pmai
Copy link
Contributor

@pmai pmai commented Dec 4, 2023

As decided in the CCB 2023-12-04 based on the issue fixed in #744, this adds checks to the build infrastructure to check that all proto files are actually referenced in CMakeLists.txt and setup.py.

@pmai pmai added the Quality Quality improvements. label Dec 4, 2023
@pmai pmai added this to the V3.7.0 milestone Dec 4, 2023
@pmai pmai self-assigned this Dec 4, 2023
ClemensLinnhoff
ClemensLinnhoff approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the action commands locally against the old master branch and it reported the missing osi_trafficcommandupdate in the CMakeLists. So it seems to work.

@pmai pmai force-pushed the build/check-proto-build-setup branch from b252619 to b447ef9 Compare January 15, 2024 16:29
@pmai pmai force-pushed the build/check-proto-build-setup branch from b447ef9 to 2a9c93c Compare March 8, 2024 10:13
@pmai
Add check that all proto files are included in build
5e06e28 
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@pmai pmai force-pushed the build/check-proto-build-setup branch from 2a9c93c to 5e06e28 Compare March 8, 2024 15:50
@pmai pmai merged commit c60c72a into OpenSimulationInterface:master Mar 8, 2024
5 checks passed
@pmai pmai deleted the build/check-proto-build-setup branch March 8, 2024 16:26
@pmai pmai added the ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. label Apr 4, 2024
@jdsika
Copy link
Contributor

jdsika commented Apr 24, 2024

Reviewed v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClemensLinnhoff ClemensLinnhoff ClemensLinnhoff approved these changes

@jdsika jdsika Awaiting requested review from jdsika

@PhRosenberger PhRosenberger Awaiting requested review from PhRosenberger

Assignees

@pmai pmai

Labels
Quality Quality improvements. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pmai @jdsika @ClemensLinnhoff