-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add a 'packageManager' version #8828
Conversation
When following the [official procedure](https://yarnpkg.com/getting-started/install) to install `yarn`, `corepack` yells about not finding a `packageManager` defined in `package.json`, and then choose one to add it. ``` ! Corepack is about to download https://registry.yarnpkg.com/yarn/-/yarn-1.22.22.tgz ? Do you want to continue? [Y/n] Y ! The local project doesn't define a 'packageManager' field. Corepack will now add one referencing yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e. ! For more details about this field, consult the documentation at https://nodejs.org/api/packages.html#packagemanager ``` :warning: It is to be noted that `yarn` documents installation through `corepack` which itself is still [experimental](https://nodejs.org/api/corepack.html#corepack). Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
Does dependabot support upgrading this field? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8828 +/- ##
============================================
- Coverage 37.07% 37.06% -0.01%
Complexity 2212 2212
============================================
Files 1255 1255
Lines 114111 114111
Branches 3189 3189
============================================
- Hits 42307 42297 -10
- Misses 69907 69917 +10
Partials 1897 1897
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR !
I wonder if we should just live with the warning instead of hardcoding a version which will quickly become outdated. |
By the way, an outdated package manager is not great because that program is responsible for doing a bunch of network requests, unpacking and writing files to disk. A vulnerability in there would have pretty unfortunate consequences, especially if the tool is pinned to a vulnerable version. |
Note that this is not just a warning, it also modify the |
OK, found a way to silence it in the documentation. Just need a |
Possible workarounds:
EDIT: ah, seems like you've found the first one already :P |
When following the official procedure to install
yarn
,corepack
yells about not finding apackageManager
defined inpackage.json
,and then choose one to add it.
yarn
documents installation throughcorepack
which itself is still experimental.