raster.c: Use sRGB if driver is pwg/urf and has ColorModel option #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some driverless printers (EPSON L3160 in Fedora report) stopped working after commit c6175a2 if `ColorModel=RGB` is passed as option. A different CUPS color space is assigned with the fix - CUPS_CSPACE_RGB, which results in no ICC profile being assigned into Ghostscript command line. Probably we can try other .icc profiles with CUPS_CSPACE_RGB (srgb.icc does not work with RGB color space), but I tested with reporter that using sRGB space + srgb.icc works for the printer - so the patch is to use sRGB if the driver is URF/PWG.
tillkamppeter
approved these changes
Mar 7, 2024
|
@zdohnal thanks for the fix. I have applied it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some driverless printers (EPSON L3160 in Fedora report) stopped working after commit c6175a2 if
ColorModel=RGBis passed as option. A different CUPS color space is assigned with the fix - CUPS_CSPACE_RGB, which results in no ICC profile being assigned into Ghostscript command line.Probably we can try other .icc profiles with CUPS_CSPACE_RGB (srgb.icc does not work with RGB color space), but I tested with reporter that using sRGB space + srgb.icc works for the printer - so the patch is to use sRGB if the driver is URF/PWG.