Handle undefined symbols in .ocd export #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes multiple issues with .ocd export. Line and point objects were exported with symbol number 0 while the typical value for such objects is -1. Text object export routines didn't recognize the undefined text symbol and choke on it, failing to export previously imported objects. Closes OpenOrienteeringGH-2012.
|
@lpechacek: thank you for providing the fix. Exporting the test map works fine as well as opening it with OCAD12. |
|
Given the positive feedback from testing, I'm merging the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A real fix to the .ocd export issue reported by users. Feel free to edit/reimplement it to your liking.