Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff bind reorg #49

Merged
merged 53 commits into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
4e0bdc9
feat: add cftoolkit v0.6.0 w rmarkdown
rroutsong Aug 15, 2024
73f27db
fix: inherit from docker v0.5.0
rroutsong Aug 16, 2024
8f402ec
feat: move to static images for diff bind and uropa rules
rroutsong Aug 19, 2024
368a33a
fix: rework diff bind and uropa scripts for modularity and new rules
rroutsong Aug 19, 2024
08ad2fa
fix: fix hooks, split diff bind and uropa into multiple rule hierarch…
rroutsong Aug 19, 2024
c1c7ff2
chore: remove planned new docker version
rroutsong Aug 19, 2024
bbf2310
fix: full path for config
rroutsong Aug 19, 2024
d641467
fix: set cwd at rule instead of script
rroutsong Aug 20, 2024
0f78a9e
fix: cd to output dir in diff bind rule
rroutsong Aug 20, 2024
b77b72e
fix: make sif cache aware of env
rroutsong Aug 20, 2024
746452f
fix: review changes
rroutsong Aug 20, 2024
8ce07d2
fix: syntax error with rmarkdown::render
rroutsong Aug 20, 2024
9d200d7
fix: images not image
rroutsong Aug 20, 2024
c16ac7b
fix: remove references to container sif files
rroutsong Aug 20, 2024
cacbd3a
fix: pathing in rmarkdown and syntax in prep_diffbind
rroutsong Aug 20, 2024
2063dbd
fix: split diffbind rules into multiple use cases
rroutsong Sep 3, 2024
f2d3e83
fix: retool rule resources
rroutsong Sep 3, 2024
b9df531
chore: merge main
rroutsong Sep 3, 2024
74d241b
fix: testing changes
rroutsong Sep 6, 2024
5e847c5
fix: finalize validation fixes
rroutsong Sep 9, 2024
1398faa
fix: additional uropa_prep_in updates
rroutsong Sep 10, 2024
e0db6d0
Update DiffBind_v2_EdgeR_block.Rmd
tovahmarkowitz Sep 12, 2024
b87ef5a
fix: take output from diffbind_count in to uropa
rroutsong Sep 12, 2024
ea3f40d
Merge branch 'diff_bind_reorg' of http://github.com/OpenOmics/chrom-s…
rroutsong Sep 12, 2024
6844d88
fix: remove up down bed outputs from edger blocking rule
rroutsong Sep 12, 2024
8a3f9ac
chore: begin to seperate uropa prep inputs
rroutsong Sep 12, 2024
61901ec
fix: rereouting everything to single application rules
rroutsong Sep 17, 2024
20e3d35
fix: wildcard correction for expanded dba rules
rroutsong Sep 20, 2024
d0bdfd0
chore: resource allocation for dba rules update
rroutsong Sep 20, 2024
e4b6c2a
feat: validation of cfchip pipeline
rroutsong Sep 24, 2024
a3f9437
fix: uropa prep rule args
rroutsong Sep 24, 2024
50c7b4a
feat: add uropa dockerfile
rroutsong Oct 7, 2024
61d4bd3
chore: add uropa update
rroutsong Oct 7, 2024
0e6b5fa
fix: make new uropa container from bioconda
rroutsong Oct 7, 2024
8929e56
fix: align inputs scripts and rules for diffbind and uropa functionality
rroutsong Oct 11, 2024
ec5e985
Merge branch 'diff_bind_reorg' of http://github.com/OpenOmics/chrom-s…
rroutsong Oct 11, 2024
5fac49a
feat: update resources on master job for local jobs
rroutsong Oct 11, 2024
353534b
fix: remove LANG def
rroutsong Oct 16, 2024
a9a2ab9
feat: new deduplication docker image
rroutsong Oct 23, 2024
94520db
fix: straighten out dedup dockerfile
rroutsong Oct 23, 2024
495f6aa
allow for uropa settings on cli instead of json key values
rroutsong Oct 24, 2024
c97b396
linted
rroutsong Oct 24, 2024
b353112
parameterize new jobs
rroutsong Oct 24, 2024
d99e84a
add new containers
rroutsong Oct 24, 2024
a334d43
reconfigure how snakemake interacts with singularity
rroutsong Oct 24, 2024
1afbf1d
workflow changes for refactor of cfchip + diffbind + uropa sections
rroutsong Oct 24, 2024
d190029
space
rroutsong Oct 24, 2024
e298199
fix: account for genrich rules
rroutsong Oct 24, 2024
ba2b91c
feat: add rule for removing edger label from uropa outputs
rroutsong Oct 25, 2024
57d27bb
Update DiffBind_v2_Deseq2.Rmd
tovahmarkowitz Oct 25, 2024
26953c4
review changes
rroutsong Oct 25, 2024
1bc5d91
Merge branch 'diff_bind_reorg' of http://github.com/OpenOmics/chrom-s…
rroutsong Oct 25, 2024
58008ea
fix: new time for trim
rroutsong Oct 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/prep_diffbind.py
rroutsong marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from os.path import join


def main(condition, peaktool, peakext, peakcaller, csvfile, wp, bam_dir):
def main(contrast, peaktool, peakext, peakcaller, csvfile, wp, bam_dir):
config = json.load(open(join(wp, "config.json")))
chip2input = config['project']['peaks']['inputs']
groupdata = config['project']['groups']
Expand All @@ -21,7 +21,7 @@ def main(condition, peaktool, peakext, peakcaller, csvfile, wp, bam_dir):

samplesheet = []
# {group1}_vs_{group2} == condition
g1, g2 = condition.split('_')[0], condition.split('_')[2]
g1, g2 = contrast.split('_')[0], contrast.split('_')[2]
for group in [g1, g2]:
for chip in groupdata[group]:
replicate = str([ i + 1 for i in range(len(groupdata[group])) if groupdata[group][i]== chip ][0])
Expand Down
27 changes: 18 additions & 9 deletions config/cluster.json
rroutsong marked this conversation as resolved.
Show resolved Hide resolved
rroutsong marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -99,21 +99,29 @@
},
"diffbindQC": {
"threads": "16",
"mem": "120g"
"mem": "150g"
},
"diffbind": {
"diffbind_deseq": {
"threads": "16",
"mem": "120g"
"mem": "150g"
},
"diffbind_blocking": {
"diffbind_edger": {
"threads": "16",
"mem": "120g"
"mem": "150g"
},
"diffbind_edger_blocking": {
"threads": "16",
"mem": "150g"
},
"diffbind_deseq_blocking": {
"threads": "16",
"mem": "150g"
},
"diffbind_count": {
"threads": "16",
"mem": "120g"
},
"UROPA_macsN": {
"UROPA_macsNarrow": {
"threads": "16",
"mem": "32g",
"time": "1-00:00:00"
Expand All @@ -129,10 +137,11 @@
"time": "1-00:00:00"
},
"MEME": {
"threads": "2",
"threads": "28",
"mem": "32g",
"time": "3-00:00:00",
"ntasks": "28",
"ntasks_per_core": "1"
"ntasks": "--ntasks=28",
"ntasks_per_core": "--ntasks-per-core=1",
"exclusive": "--exclusive"
}
}
3 changes: 1 addition & 2 deletions config/containers.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"cfchip": "docker://skchronicles/cfchip_toolkit:v0.5.0",
"uropa": "docker://rroutsong/uropa:4.0.3",
"python": "docker://asyakhleborodova/chrom_seek_python:v0.1.0",
"ppqt": "docker://asyakhleborodova/ppqt:v0.2.0",
"dedup": "docker://rroutsong/chrom_seek_dedup:0.0.1"
"ppqt": "docker://asyakhleborodova/ppqt:v0.2.0"
}
}
2 changes: 1 addition & 1 deletion workflow/rules/uropa.smk
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ rule UROPA_prep_in_macsN:
""")


rule UROPA_macsN:
rule UROPA_macsNarrow:
input: join(uropa_dir, "macsNarrow", "{name}.macsNarrow.{_type}.json")
params:
rname = "UROPA_macsN",
Expand Down
Loading