Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding chip motif analysis tool, MEME rule #26

Merged
merged 1 commit into from
Nov 16, 2023
Merged

adding chip motif analysis tool, MEME rule #26

merged 1 commit into from
Nov 16, 2023

Conversation

asyakhl
Copy link
Contributor

@asyakhl asyakhl commented Nov 16, 2023

No description provided.

@asyakhl asyakhl requested a review from skchronicles November 16, 2023 19:06
bedtools getfasta -fi {params.ref_fa} -bed {input.bed} -fo ${{tmp}}/{params.outfa}
meme-chip \\
--oc {params.oc}_meme \\
-db {params.meme_vertebrates_db} \\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asyakhl Will this work if a user selects rheMac10 as the genome? For this reference genome, it is set to an empty string. I am not sure if that will cause an error when it runs:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does cause a problem, can we add a lambda statement to build the -db DB string within the params section of the snakemake rule?

@skchronicles
Copy link
Contributor

Hey @asyakhl,

Everything looks great! Can you please let me know what you think about the thread above? I am not sure if we should make the -db DB option dynamically resolved with a lambda statement.

@skchronicles
Copy link
Contributor

Everything looks perfect! Please ignore my initial comment about the db for rheMac10.

@skchronicles skchronicles merged commit 5b04d41 into main Nov 16, 2023
1 check passed
@skchronicles skchronicles deleted the MEME branch February 5, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants