This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Commenting code #164
Merged
Commenting code #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamtrask
pushed a commit
that referenced
this pull request
Mar 31, 2018
* First round of torch hooks integration (#152) * Finished HookService, linked it with TorchService (#154) * feat: modify pubsub_peers to handle newer IPFS api. (#153) * finished minimal transfer of overloading code * found an untested bug * WIP for #130 and #132 (#155) * feat: modify pubsub_peers to handle newer IPFS api. (#153) * finished minimal transfer of overloading code * found an untested bug * adjust comments * this round of work sponsored by parallel jalebi * in the middle of fixing #130 and #132 * resolved #132, #130 will take a bit more effort than I'd planned for * completes #130, prepares #129 and #131; almost took care of #148 in the process * Worker side command processing and execution (#156) resolved #129 * Finished implementing IPFS into torch services (#161) * laptop sync * finished up ipfs integration, yet to test * syncing with colab notebooks * renamed channels.openmined to channels.om * found a worker node error * bug in Tensor.send_ * fixed two client side bugs * keyerror in receive_obj message * register tensors before sending * well that was rough * more bug fixes * premerge * fix utils import in hook_worker_service * fix return_result for worker * premerge * premerge2 * BOOM * multinode demo (#162) * lots o' comments (#164) * Reorganizing notebooks (#165) * lots o' comments * reorganize notebooks
Benardi
pushed a commit
that referenced
this pull request
May 12, 2020
* First round of torch hooks integration (#152) * Finished HookService, linked it with TorchService (#154) * feat: modify pubsub_peers to handle newer IPFS api. (#153) * finished minimal transfer of overloading code * found an untested bug * WIP for #130 and #132 (#155) * feat: modify pubsub_peers to handle newer IPFS api. (#153) * finished minimal transfer of overloading code * found an untested bug * adjust comments * this round of work sponsored by parallel jalebi * in the middle of fixing #130 and #132 * resolved #132, #130 will take a bit more effort than I'd planned for * completes #130, prepares #129 and #131; almost took care of #148 in the process * Worker side command processing and execution (#156) resolved #129 * Finished implementing IPFS into torch services (#161) * laptop sync * finished up ipfs integration, yet to test * syncing with colab notebooks * renamed channels.openmined to channels.om * found a worker node error * bug in Tensor.send_ * fixed two client side bugs * keyerror in receive_obj message * register tensors before sending * well that was rough * more bug fixes * premerge * fix utils import in hook_worker_service * fix return_result for worker * premerge * premerge2 * BOOM * multinode demo (#162) * lots o' comments (#164) * Reorganizing notebooks (#165) * lots o' comments * reorganize notebooks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed compile_result and receive_obj_break to handle numeric outputs of torch commands.