Merge pull request #5118 from martin-frbg/zrot_utestext

Disable extended utests for CSROT/ZDROT that invoke undefined behavior
OpenMathLib · Feb 9, 2025 · c54f541 · c54f541
2 parents 1b85b6a + 57208b8
commit c54f541
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/utest/test_extensions/test_crot.c b/utest/test_extensions/test_crot.c
@@ -166,7 +166,7 @@ static float c_api_check_csrot(blasint n, blasint inc_x, blasint inc_y, float *c
     norm += cblas_scnrm2(n, data_crot.y_test, inc_y_abs);
     return (norm / 2);
 }
-
+#if 0
 /**
  * Fortran API specific test
  * Test crot by comparing it with caxpby.
@@ -192,7 +192,7 @@ CTEST(crot, inc_x_0_inc_y_0)
     float norm = check_csrot(n, inc_x, inc_y, c, s);
     ASSERT_DBL_NEAR_TOL(0.0f, norm, SINGLE_EPS);
 }
-
+#endif
 /**
  * Fortran API specific test
  * Test crot by comparing it with caxpby.
@@ -478,7 +478,7 @@ CTEST(crot, check_n_zero)
     float norm = check_csrot(n, inc_x, inc_y, c, s);
     ASSERT_DBL_NEAR_TOL(0.0f, norm, SINGLE_EPS);
 }
-
+#if 0
 /**
  * C API specific test 
  * Test crot by comparing it with caxpby.
@@ -504,7 +504,7 @@ CTEST(crot, c_api_inc_x_0_inc_y_0)
     float norm = c_api_check_csrot(n, inc_x, inc_y, c, s);
     ASSERT_DBL_NEAR_TOL(0.0f, norm, SINGLE_EPS);
 }
-
+#endif
 /**
  * C API specific test
  * Test crot by comparing it with caxpby.

diff --git a/utest/test_extensions/test_zrot.c b/utest/test_extensions/test_zrot.c
@@ -164,7 +164,7 @@ static double c_api_check_zdrot(blasint n, blasint inc_x, blasint inc_y, double
     norm += cblas_dznrm2(n, data_zrot.y_test, inc_y_abs);
     return (norm / 2);
 }
-
+#if 0
 /**
  * Fortran API specific test
  * Test zrot by comparing it with zaxpby.
@@ -190,7 +190,7 @@ CTEST(zrot, inc_x_0_inc_y_0)
     double norm = check_zdrot(n, inc_x, inc_y, c, s);
     ASSERT_DBL_NEAR_TOL(0.0, norm, DOUBLE_EPS);
 }
-
+#endif
 /**
  * Fortran API specific test
  * Test zrot by comparing it with zaxpby.
@@ -476,7 +476,7 @@ CTEST(zrot, check_n_zero)
     double norm = check_zdrot(n, inc_x, inc_y, c, s);
     ASSERT_DBL_NEAR_TOL(0.0, norm, DOUBLE_EPS);
 }
-
+#if 0
 /**
  * C API specific test 
  * Test zrot by comparing it with zaxpby.
@@ -502,7 +502,7 @@ CTEST(zrot, c_api_inc_x_0_inc_y_0)
     double norm = c_api_check_zdrot(n, inc_x, inc_y, c, s);
     ASSERT_DBL_NEAR_TOL(0.0, norm, DOUBLE_EPS);
 }
-
+#endif
 /**
  * C API specific test
  * Test zrot by comparing it with zaxpby.