Skip to content

Commit

Permalink
Revert #1246, "honor cgroup/cpuset limits" for now
Browse files Browse the repository at this point in the history
Unsafe usage of the __GLIBC_PREREQ macro lead to build breakage on non-glibc systems
  • Loading branch information
martin-frbg authored Jul 25, 2017
1 parent 5dde4e6 commit 88a35ff
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 81 deletions.
49 changes: 5 additions & 44 deletions driver/others/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -778,11 +778,11 @@ static int initialized = 0;
void gotoblas_affinity_init(void) {

int cpu, num_avail;
#ifndef USE_OPENMP
#ifndef USE_OPENMP
cpu_set_t cpu_mask;
#endif
int i;

if (initialized) return;

initialized = 1;
Expand Down Expand Up @@ -826,54 +826,15 @@ void gotoblas_affinity_init(void) {
common -> shmid = pshmid;

if (common -> magic != SH_MAGIC) {
cpu_set_t *cpusetp;
int nums;
int ret;

#ifdef DEBUG
fprintf(stderr, "Shared Memory Initialization.\n");
#endif

//returns the number of processors which are currently online

nums = sysconf(_SC_NPROCESSORS_CONF);

#if !defined(__GLIBC_PREREQ) || !__GLIBC_PREREQ(2, 3)
common->num_procs = nums;
#elif __GLIBC_PREREQ(2, 7)
cpusetp = CPU_ALLOC(nums);
if (cpusetp == NULL) {
common->num_procs = nums;
} else {
size_t size;
size = CPU_ALLOC_SIZE(nums);
ret = sched_getaffinity(0,size,cpusetp);
if (ret!=0)
common->num_procs = nums;
else
common->num_procs = CPU_COUNT_S(size,cpusetp);
}
CPU_FREE(cpusetp);
#else
ret = sched_getaffinity(0,sizeof(cpu_set_t), cpusetp);
if (ret!=0) {
common->num_procs = nums;
} else {
#if !__GLIBC_PREREQ(2, 6)
int i;
int n = 0;
for (i=0;i<nums;i++)
if (CPU_ISSET(i,cpusetp)) n++;
common->num_procs = n;
}
#else
common->num_procs = CPU_COUNT(sizeof(cpu_set_t),cpusetp);
#endif

#endif
common -> num_procs = sysconf(_SC_NPROCESSORS_CONF);;

if(common -> num_procs > MAX_CPUS) {
fprintf(stderr, "\nOpenBLAS Warning : The number of CPU/Cores(%d) is beyond the limit(%d). Terminated.\n", common->num_procs, MAX_CPUS);
fprintf(stderr, "\nOpenBLAS Warining : The number of CPU/Cores(%d) is beyond the limit(%d). Terminated.\n", common->num_procs, MAX_CPUS);
exit(1);
}

Expand All @@ -886,7 +847,7 @@ void gotoblas_affinity_init(void) {
if (common -> num_nodes > 1) numa_mapping();

common -> final_num_procs = 0;
for(i = 0; i < common -> avail_count; i++) common -> final_num_procs += rcount(common -> avail[i]) + 1; //Make the max cpu number.
for(i = 0; i < common -> avail_count; i++) common -> final_num_procs += rcount(common -> avail[i]) + 1; //Make the max cpu number.

for (cpu = 0; cpu < common -> final_num_procs; cpu ++) common -> cpu_use[cpu] = 0;

Expand Down
37 changes: 0 additions & 37 deletions driver/others/memory.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,44 +175,7 @@ int get_num_procs(void);
#else
int get_num_procs(void) {
static int nums = 0;
cpu_set_t *cpusetp;
size_t size;
int ret;
int i,n;

if (!nums) nums = sysconf(_SC_NPROCESSORS_CONF);
#if !defined(OS_LINUX)
return nums;
#endif

#if !defined(__GLIBC_PREREQ)
return nums;
#endif
#if !__GLIBC_PREREQ(2, 3)
return nums;
#endif

#if !__GLIBC_PREREQ(2, 7)
ret = sched_getaffinity(0,sizeof(cpu_set_t), cpusetp);
if (ret!=0) return nums;
n=0;
#if !__GLIBC_PREREQ(2, 6)
for (i=0;i<nums;i++)
if (CPU_ISSET(i,cpusetp)) n++;
nums=n;
#else
nums = CPU_COUNT(sizeof(cpu_set_t),cpusetp);
#endif
return nums;
#endif

cpusetp = CPU_ALLOC(nums);
if (cpusetp == NULL) return nums;
size = CPU_ALLOC_SIZE(nums);
ret = sched_getaffinity(0,size,cpusetp);
if (ret!=0) return nums;
nums = CPU_COUNT_S(size,cpusetp);
CPU_FREE(cpusetp);
return nums;
}
#endif
Expand Down

0 comments on commit 88a35ff

Please sign in to comment.