Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace call to deprecated function in Mage_Eav #862

Merged
merged 1 commit into from
Nov 27, 2019
Merged

replace call to deprecated function in Mage_Eav #862

merged 1 commit into from
Nov 27, 2019

Conversation

rjocoleman
Copy link
Contributor

Mage_Eav has a call to each which is deprecated as of PHP 7.2 https://www.php.net/manual/en/function.each.php

@rjocoleman
replace call to deprecated function in Mage_Eav
0d70d2d 
`Mage_Eav` has a call to `each` which is deprecated as of PHP 7.2 https://www.php.net/manual/en/function.each.php
Flyingmana
Flyingmana approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably also good, as each() is moving the array pointer.
Not relevant for arrays here, as its not passByReference... anyway, good change, unlikely it has negative side effects.

anyway: good find

@colinmollenhour colinmollenhour merged commit 0a1d5f0 into OpenMage:1.9.4.x Nov 27, 2019
@rjocoleman rjocoleman deleted the patch-2 branch November 27, 2019 09:11
@sreichel sreichel added Component: Eav Relates to Mage_Eav PHP7 labels Jun 5, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@rjocoleman @edannenberg
[bug-OpenMage#862] Deprecated each() call in Mage_Eav with PHP 7.2
7c2a876 
See https://www.php.net/manual/en/function.each.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

Assignees
No one assigned
Labels
Component: Eav Relates to Mage_Eav
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjocoleman @colinmollenhour @Flyingmana @sreichel