FIX. Enable re-sending again - http://magento.stackexchange.com/a/376… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…90/78 FIX. Enable re-sending again - http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent ... fixed
|
I think the better solution is to switch to |
|
As long as the problem is fixed ;P Can you create a pull request and add it? |
|
Can this be accepted? |
|
+1 for the @shirtsofholl solution |
colinmollenhour
requested changes
Oct 10, 2016
| @@ -136,6 +136,8 @@ public function emailAction() | |||
| { | |||
| if ($order = $this->_initOrder()) { | |||
| try { | |||
| // FIX. Enable re-sending again - http://magento.stackexchange.com/a/37690/78 | |||
| $order->setEmailSent(false); | |||
There was a problem hiding this comment.
Tabs vs spaces... We gotta have some standards.. :)
There was a problem hiding this comment.
Agree .... +1 .. just get this one in ;)
There was a problem hiding this comment.
Preferred way to fix is while on your PR branch just replace the tabs with spaces, use git commit -a --amend to fix the existing commit and then git push -f to force-push over the old commit.
There was a problem hiding this comment.
I think fixed now no?
colinmollenhour
approved these changes
Oct 11, 2016
|
Merged 1.9.2.3 into 1.9.3.0 |
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Dec 6, 2017
http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 28, 2018
http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Jul 17, 2018
http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Sep 19, 2018
http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 14, 2019
http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Apr 1, 2019
http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
http://magento.stackexchange.com/a/37690/78 Irritating "new" feature so order emails cannot be resent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…90/78
FIX. Enable re-sending again - http://magento.stackexchange.com/a/37690/78
Irritating "new" feature so order emails cannot be resent ... fixed