Disable select-all for large collections. #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmollenhour
approved these changes
Jan 26, 2019
dng-dev
approved these changes
Jan 26, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 14, 2019
… grids Disable select-all to prevent oom with large collections
fplantinet
pushed a commit
to fplantinet/magento-lts
that referenced
this pull request
Mar 27, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Apr 1, 2019
… grids Disable select-all to prevent oom with large collections
rafaelpatro
pushed a commit
to rafaelpatro/magento-lts
that referenced
this pull request
May 14, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
… grids Disable select-all to prevent oom with large collections
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
… grids Disable select-all to prevent oom with large collections
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
… grids Disable select-all to prevent oom with large collections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tables with a particularly large number of records, it may be useful to disable the front end 'select-all' for performance reasons. Reduces likelihood of encountering PHP memory limit issues in these cases.