Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php8.3: fix deprecated passing null to str_replace() #4525

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Feb 2, 2025

Description (*)

PHP Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in /home/runner/work/magento-lts/magento-lts/lib/Varien/Object.php on line 592

@sreichel sreichel added bug PHP 8.3 Related to PHP 8.3 labels Feb 2, 2025
@github-actions github-actions bot added Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* phpunit labels Feb 2, 2025
@sreichel sreichel changed the title php8.3: fix passing null to str_replace() php8.3: fix deprecated passing null to str_replace() Feb 2, 2025
addison74
addison74 previously approved these changes Feb 2, 2025
@sreichel sreichel added this to the 20.13.0 milestone Feb 2, 2025
@sreichel sreichel marked this pull request as draft February 4, 2025 11:10
@sreichel sreichel marked this pull request as ready for review February 4, 2025 11:29
Copy link

sonarqubecloud bot commented Feb 4, 2025

@sreichel sreichel requested a review from Hanmac February 10, 2025 16:03
@sreichel sreichel merged commit bf95ffc into OpenMage:main Feb 10, 2025
17 checks passed
@sreichel sreichel deleted the php83-str_replace branch February 10, 2025 16:47
fballiano added a commit to MahoCommerce/maho that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* PHP 8.3 Related to PHP 8.3 phpunit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated: str_replace(): Passing null to parameter #2 ($replace)
3 participants