php 8.3: fix catch for empty sitemap filename #4521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
With PHP 7.4 this catch will catch empty filename exception. With PHP 8.3, empty filename escapes the catch, because it is type of
ValueError
which does not inherit fromException
. This PR fixes the catch, that PHP 8.3 behavior is the same as PHP 7.4full PHP 8.3 error that escapes the catch
Manual testing scenarios (*)
sitemap_generate
Contribution checklist (*)