Fix issue with double port in error pages base URL #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have polyfills for php8, you can use PS: please run |
|
Thanks for the feedback, i run CS fixer and changed the code to use |
|
sreichel
approved these changes
Feb 2, 2025
addison74
approved these changes
Feb 2, 2025
|
@all-contributors add @massa-man code |
|
@massa-man already contributed before to code |
|
Thanks. |
sreichel
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This fixes an issue where the base URL injected into the error page HTML HEAD includes the port twice, and breaks the CSS and image imports. This happens because the code uses HTTP_HOST server variable that already includes the port if the browser URL has a port.
Manual testing scenarios (*)
http://localhost:8080http://localhost:8080/errors/404.php<head>the<base>element has a URL likehttp://localhost:8080:8080/errors/default/Questions or comments
The code uses
substr_compareinstead ofstr_ends_withfor php 7 compatibility.Contribution checklist (*)