Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpUnit: updated and added tests #4454

Merged
merged 39 commits into from
Feb 6, 2025
Merged

PhpUnit: updated and added tests #4454

merged 39 commits into from
Feb 6, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 6, 2025

No description provided.

@sreichel
bumped version
ee90d05
@sreichel
updated tests
c21fe6b
@sreichel
Merge branch 'main' into phpunit-dates
61dd0f6 
# Conflicts:
#	tests/unit/Mage/Catalog/Model/Resource/Eav/AttributeTest.php
@sreichel sreichel marked this pull request as draft January 6, 2025 15:06
@sreichel sreichel added the chore label Jan 6, 2025
@sreichel sreichel added this to the 20.12.0 milestone Jan 6, 2025
@sreichel sreichel marked this pull request as ready for review January 6, 2025 22:10
@sreichel sreichel modified the milestones: 20.12.0, 20.13.0 Jan 6, 2025
@sreichel sreichel mentioned this pull request Jan 8, 2025
Closed
@sreichel sreichel mentioned this pull request Jan 15, 2025
Closed
@sreichel sreichel marked this pull request as ready for review January 15, 2025 23:03
@sreichel sreichel requested review from addison74 and kiatng January 15, 2025 23:04
@sreichel sreichel requested a review from Hanmac January 18, 2025 01:00
@sreichel
Merge branch 'main' into phpunit-dates
f7123ea 
# Conflicts:
#	composer.lock
@sreichel
Copy link
Contributor Author

@kiatng id like to cover changed methods like in #4500. This PR is "required" to continue.

@sreichel sreichel mentioned this pull request Feb 6, 2025
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

colinmollenhour
colinmollenhour approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sreichel sreichel merged commit eb0e774 into OpenMage:main Feb 6, 2025
19 checks passed
@sreichel sreichel deleted the phpunit-dates branch February 6, 2025 18:38
fballiano added a commit to MahoCommerce/maho that referenced this pull request Feb 6, 2025
@fballiano
OM PR 4454
66dd193 
OpenMage/magento-lts#4454
fballiano added a commit to MahoCommerce/maho that referenced this pull request Feb 6, 2025
@fballiano
OM PR 4454
c8a75cf 
OpenMage/magento-lts#4454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@addison74 addison74 addison74 approved these changes

@kiatng kiatng Awaiting requested review from kiatng

@Hanmac Hanmac Awaiting requested review from Hanmac

Assignees
No one assigned
Labels
chore Component: Index Relates to Mage_Index Component: Reports Relates to Mage_Reports composer Relates to composer.json ddev php-cs-fixer phpstan phpunit rector
Projects
None yet
Milestone
20.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @kiatng @addison74