Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more PhpUnit tests #4236

Merged
merged 40 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
9466a80
Updated tests
sreichel Sep 30, 2024
9d32ba5
Typo
sreichel Sep 30, 2024
9f52d94
Docs
sreichel Sep 30, 2024
93155dc
Fixe test
sreichel Sep 30, 2024
bc69376
ddev commands
sreichel Sep 30, 2024
3b8f825
Docs
sreichel Sep 30, 2024
0aab349
phpstan.baseline
sreichel Sep 30, 2024
ad70216
composer.lock
sreichel Sep 30, 2024
5d485de
Added tests
sreichel Sep 30, 2024
321b544
phpcs
sreichel Sep 30, 2024
4c68908
Updated test: pass invalid storeId
sreichel Sep 30, 2024
2d1969f
Bugfix: Mage_Catalog_Model_Url::refreshRewrites()
sreichel Sep 30, 2024
ea06b7b
Updated test
sreichel Sep 30, 2024
21f29a2
Updated test
sreichel Sep 30, 2024
a31ab10
Updated tests
sreichel Oct 1, 2024
b76af2c
Updated tests
sreichel Oct 1, 2024
aea0871
Merge remote-tracking branch 'origin/phpunit' into phpunit
sreichel Oct 1, 2024
cd03fc9
Merge branch 'main' into phpunit
sreichel Oct 2, 2024
4368716
Merge branch 'main' into phpunit
sreichel Oct 8, 2024
915a974
return int for store_id
sreichel Oct 9, 2024
9fe3ea8
Merge branch 'main' into phpunit
sreichel Oct 9, 2024
f13001d
updated tests
sreichel Oct 9, 2024
b331ed8
Merge remote-tracking branch 'origin/phpunit' into phpunit
sreichel Oct 9, 2024
323b7c7
Merge branch 'main' into phpunit
sreichel Oct 9, 2024
bf7757c
Merge branch 'main' into phpunit
sreichel Oct 13, 2024
080b6f6
Merge branch 'main' into phpunit
sreichel Oct 14, 2024
437c5d2
Merge branch 'main' into phpunit
sreichel Oct 14, 2024
bfd5297
cs [skip ci]
sreichel Oct 14, 2024
b72f35d
Mage_Eav_Model_Entity_Type fixes
sreichel Oct 16, 2024
4a38080
phpstan fixed errors
sreichel Oct 16, 2024
9eee918
Merge branch 'main' into phpunit
sreichel Oct 16, 2024
edd44b0
Merge branch 'main' into phpunit
sreichel Oct 16, 2024
83eb7b7
Merge remote-tracking branch 'origin/phpunit' into phpunit
sreichel Oct 16, 2024
4809a08
updated tests
sreichel Oct 16, 2024
4371d80
Merge branch 'main' into phpunit
sreichel Oct 16, 2024
aa4b27a
Merge branch 'main' into phpunit
sreichel Oct 18, 2024
0cb8539
Merge branch 'main' into phpunit
sreichel Oct 18, 2024
1b46390
Merge branch 'main' into phpunit
sreichel Oct 18, 2024
96bf962
Merge branch 'main' into phpunit
sreichel Oct 23, 2024
c877370
reverted
sreichel Oct 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
phpcs
  • Loading branch information
sreichel committed Sep 30, 2024
commit 321b54419c2001981f8339da6328db9290561c16
4 changes: 2 additions & 2 deletions tests/unit/Mage/Catalog/Model/ProductTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function testGetStoreId(): void
$this->assertSame('1', $this->subject->getStoreId());
}

/**
/**
* @group Mage_Catalog
* @group Mage_Catalog_Model
*/
Expand All @@ -54,7 +54,7 @@ public function testGetResourceCollection(): void
$this->assertInstanceOf(Mage_Catalog_Model_Resource_Product_Collection::class, $this->subject->getResourceCollection());
}

/**
/**
* @group Mage_Catalog
* @group Mage_Catalog_Model
*/
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/Mage/Catalog/Model/UrlTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public function provideGeneratePathData(): array
null,
$category,
],
'target product' => [
'target product' => [
'catalog/product/view/id/999',
'target',
$product,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/Varien/Db/Adapter/Pdo/MysqlTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public function testGetHostInfoWithUnixSocket(): void
$hostInfo = $method->invoke($this->adapter, $fakeSocket);

$this->assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_UNIX_SOCKET, $hostInfo->getAddressType());
$this->assertSame($fakeSocket, $hostInfo->getUnixSocket(),);
$this->assertSame($fakeSocket, $hostInfo->getUnixSocket());
$this->assertNull($hostInfo->getHostName());
$this->assertNull($hostInfo->getPort());
}
Expand Down
Loading