Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation v3 📝 #3659

Closed
wants to merge 95 commits into from
Closed

Documentation v3 📝 #3659

wants to merge 95 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 16, 2023

Description (*)

Have documentation at one place!

This PR move all docs to docs/content

Questions or comments

Can ..

  • blog, install section be removed from openmage.org?
  • can readthedocs be closed?
  • local docs moved - and README cleaned?

There is nothing to do ...

... the worklow creates a branch named gh-pages, that serves the static files ...

... but ...

... the repos setting needs to point githab pages to gh-pages branch.

... and ...

... for local preview ... run mkdocs serve

Comment system

Still points to my repo and needs added here first!

Preview

https://sreichel.github.io/openmage-strict/

@github-actions github-actions bot added the ddev label Nov 16, 2023
@sreichel sreichel changed the title Documentation Documentation v3 📝 Nov 16, 2023
@fballiano
Copy link
Contributor

with some tweaks (mainly to the home page) this could replace the main website...

@kiatng
Copy link
Contributor

kiatng commented Nov 17, 2023

Is the intention to include documentation (blog) in this repo?

@sreichel
Copy link
Contributor Author

@kiatng yes, all docs should be here. Think its easier to update/add content here, not in other repos.

@kiatng
Copy link
Contributor

kiatng commented Nov 18, 2023

For those who use git to update production, what are the ways to deal with these docs? The docs are unnecessary in production.

@sreichel
Copy link
Contributor Author

sreichel commented Nov 18, 2023

Mhh ... md files are already blocked in .htacces to not expose anything.

With git you dont need no .ddev, .github, and others too .... some additional files do not harm?

@kiatng
Copy link
Contributor

kiatng commented Jan 27, 2024

Is it a good idea to prefix a dot to doc, ".doc". Existing server directive already excludes dot files from public access.

Or even better, move to another repo all together?

@sreichel
Copy link
Contributor Author

sreichel commented Jan 27, 2024

Is it a good idea to prefix a dot to doc, ".doc"

Can you please point to it? I dont see it.

Edit: it was a suggestion? I am not sure about this ... having a docs dir seems okay.

Or even better, move to another repo all together?

I read your earlier suggestion about this (related to blog post?), but docs belong here IMHO.

Another repo would make it much harder to maintain it. This is something i am against for 100% With .gitattributes we can excclude files we dont need in prod environment, Having all docs at one repo sounds better to me, We aleady have multible repos, but none is maintained ...

@kiatng
Copy link
Contributor

kiatng commented Jan 27, 2024

From PR #1209 : dev/openmage/nginx-frontend.conf and dev/openmage/nginx-admin.conf, e.g.

    # Protect dot files no matter where they are located
    location ~ /\. { return 404; }

I lack the knowledge to review the PR, but it'll be a useful addition. So, someone with better knowledge than me should help to review it.

@sreichel
Copy link
Contributor Author

sreichel commented Jan 27, 2024

In .htaccess we ready have this ...

    <FilesMatch \.(dist|flag|ip|lock|md|neon|sample|sh|yml|yaml)$>
        Order allow,deny
        Deny from all
    </FilesMatch>

... to block access to md files. nginx settings may need adjustments.

@kiatng
Copy link
Contributor

kiatng commented Jan 27, 2024

Off topic, I cannot find any solution using .gitattributes, while merging, to not create "new files" (e.g. docs and dev) in production branch. Can you provide some ideas on how to do it?

@sreichel
Copy link
Contributor Author

sreichel commented Jan 27, 2024

#3318

Install via composer should not add excluded files. Using git clone/pull will include them o/c ...

See https://github.com/OpenMage/magento-lts/pull/3659/files#diff-618cd5b83d62060ba3d027e314a21ceaf75d36067ff820db126642944145393e

/docs export-ignore
/docs_includes export-ignore

This was referenced Feb 1, 2024
@sreichel sreichel closed this by deleting the head repository Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants