-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix admin ACL mismatch for OAuth (#3272) #3274
Fix admin ACL mismatch for OAuth (#3272) #3274
Conversation
748bcc0
to
ac1ceea
Compare
ac1ceea
to
3cfee60
Compare
app/code/core/Mage/Oauth/sql/oauth_setup/upgrade-1.0.0.0-1.0.0.1.php
Outdated
Show resolved
Hide resolved
Fixed CS complaint.
app/code/core/Mage/Oauth/data/oauth_setup/upgrade-1.0.0.0-1.0.0.1.php
Outdated
Show resolved
Hide resolved
This is unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the upgrade script.
@fballiano The PHP-CS-Fixer error is related to PR #2210 and not related to this PR. Not sure what to do. |
app/code/core/Mage/Oauth/data/oauth_setup/upgrade-1.0.0.0-1.0.0.1.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested the custom role before/after the upgrade and it give access to the backend mask (which previously was unavailable)
Description (*)
This PR fixes ACL issue in Mage_Oauth adminhtml.xml that causes silent Zend_Acl_Exception throw on every admin page and no access to REST consumers/tokens for users with custom role resource access
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)