Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of ignore_user_agents #3238

Merged
merged 14 commits into from
May 13, 2023
Merged

Improved handling of ignore_user_agents #3238

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
59712fa
Improve ignore_user_agents functionality
empiricompany May 5, 2023
b7d3348
Fix wrong compare
empiricompany May 6, 2023
b186f42
update ignore_user_agents config
empiricompany May 6, 2023
f3c993d
Fix mistype
empiricompany May 6, 2023
20e8387
Update app/code/core/Mage/Log/etc/config.xml
fballiano May 7, 2023
fe20b01
Update app/code/core/Mage/Log/etc/config.xml
fballiano May 7, 2023
761f2cc
Update app/code/core/Mage/Log/etc/config.xml
fballiano May 7, 2023
6bef18a
Update app/code/core/Mage/Log/etc/config.xml
fballiano May 7, 2023
519b9e3
Update app/code/core/Mage/Log/Model/Visitor.php
fballiano May 7, 2023
b3c9dab
Update Visitor.php
fballiano May 7, 2023
46803c1
use regex instead of string comparison and reorder ignored user agents
empiricompany May 13, 2023
df80a7a
revert last commit foreach > stripos is much faster than preg_match
empiricompany May 13, 2023
752f4c4
Merge branch 'main' into patch-1
empiricompany May 13, 2023
42c5955
Merge branch 'main' into patch-1
empiricompany May 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/core/Mage/Log/Model/Visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ protected function _construct()
$ignoreAgents = $this->_config->getNode('global/ignore_user_agents');
if ($ignoreAgents) {
$ignoreAgents = $ignoreAgents->asArray();
if (in_array($userAgent, $ignoreAgents)) {
if (in_array($userAgent, $ignoreAgents) || stristr($userAgent, $ignoreAgents)) {
$this->_skipRequestLogging = true;
}
}
Expand Down