Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to add target attribute for adminhtml menu items #1985

Merged
merged 2 commits into from
Feb 6, 2022

Conversation

Sekiphp
Copy link
Contributor

@Sekiphp Sekiphp commented Jan 22, 2022

Description (*)

In OM there is currently now way how to open hyperlinks to new tabs / windows.

Usage

<menu_item translate="title">
    <title>Menu item label</title>
    <action>adminhtml/hello_world/foo</action>
    <target>_blank</target>
</menu_item>

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page Template : admin Relates to admin template labels Jan 22, 2022
@midlan
Copy link
Contributor

midlan commented Jan 22, 2022

What about framename as target?
https://www.w3schools.com/tags/att_a_target.asp

@Sekiphp
Copy link
Contributor Author

Sekiphp commented Jan 24, 2022

What about framename as target? https://www.w3schools.com/tags/att_a_target.asp

Until now, noone want it! This feature is added mainly for _blank option, which should be usable for multiple M1 websites. You are nitpicker, Milan! :-)

@midlan
Copy link
Contributor

midlan commented Jan 24, 2022

I am not nitpicker. When adding new feature I just would implement the complete current standard. By your argumentation you should just implement _blank, because you don't need the others 🙃

@Sekiphp
Copy link
Contributor Author

Sekiphp commented Jan 25, 2022

I am not nitpicker. When adding new feature I just would implement the complete current standard. By your argumentation you should just implement _blank, because you don't need the others 🙃

I'm not convienced about framename support, but I implement it.....

@Flyingmana Flyingmana merged commit bc33791 into OpenMage:1.9.4.x Feb 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit bc33791. ± Comparison against base commit 14afb4b.

@xqiu
Copy link

xqiu commented Feb 7, 2022

commit bc33791 should not change the default function signature for _buildMenuArray, some plugin may depend on this function's default behavior (e.g. https://github.com/AOEpeople/Clean_SqlReports) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page Template : admin Relates to admin template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants