don't save index events for indexers in manual mode #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bob2021 Why did you close the PR? |
|
Sorry, I should have added a comment - since I split up the changes into individual PRs I've been less convinced that this one is actually that useful so I closed it while I review it. |
mass_action are cleaned|
I tried to re-open this PR but couldn't as I had already force pushed a new version of the branch. New PR is #199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a group of PRs containing the changes discussed in issue #152
If an indexer is in manual mode, there is no need to save an index event as it will never be processed - manual mode indexes can only be updated using a full reindex.
Index event data can grow very large (megabytes) for mass_action events. It is not always cleaned properly after processing and new data is often appended without deduplicating.
This PR prevents an index event from registering with an indexer if it is in manual mode. It also ensures that index data is cleaned during a partial 'full' reindex.