Disable DISABLE KEYS statements
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cieslix
approved these changes
Mar 3, 2017
|
Would you mind rebasing or resubmitting on 1.9.3.x branch? Otherwise I approve. |
…ove useless calls to useDisableKeys()
|
Rebased on 1.9.3.x |
tmotyl
approved these changes
Mar 6, 2017
|
@colinmollenhour would you mind merging it once you approve? |
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Dec 6, 2017
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Dec 6, 2017
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 28, 2018
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Mar 20, 2018
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Jul 17, 2018
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Sep 19, 2018
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 14, 2019
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Apr 1, 2019
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
disable 'ALTER TABLE ... DISABLE KEYS' statements by default, and remove useless calls to useDisableKeys()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a group of PRs containing the changes discussed in issue #152
Indexers that extend
Mage_Index_Model_Resource_Abstractrun anALTER TABLE ... DISABLE|ENABLE KEYSstatement before and after inserting data.The statement is only supported by MyISAM tables so it is useless for modern magento installations, but it still requires a table metadata lock even if MyISAM is not used.
The catalogsearch index does still use MyISAM, but it doesn't extend
Mage_Index_Model_Resource_Abstractso it isn't affected.This PR disables the statements by default, but leaves the functionality in place if still required.
It also removes calls to
Mage_Index_Model_Resource_Abstract::useDisableKeys. In most cases it was called by mistake and had no effect (it should have beenMage_Index_Model_Resource_Abstract::disableTableKeys), but now they aren't required at all.