Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change variable name #176

Merged
merged 1 commit into from
Feb 16, 2017
Merged

change variable name #176

merged 1 commit into from
Feb 16, 2017

Conversation

alissonjr
Copy link
Contributor

$databaseFileSotrage to $databaseFileStorage

@alissonjr
change variable name
f0601ff 
**$databaseFileSotrage** to **$databaseFileStorage**
Flyingmana
Flyingmana approved these changes Feb 16, 2017
View reviewed changes
Copy link
Contributor

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally I would be against such name changes because of possible merge issues in t he future, but get.php is not touched much by changes

@Flyingmana Flyingmana merged commit fb4fe3a into OpenMage:1.9.3.x Feb 16, 2017
@tmotyl tmotyl mentioned this pull request Mar 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeSaferite LeeSaferite LeeSaferite approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

Assignees
No one assigned
Labels
Cleanup: Typos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alissonjr @LeeSaferite @Flyingmana @sreichel