Improve layout cache efficiency by de-duplicating XML strings. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dus not sive info the code ... But how would this influence FPC cache extensions like lesti, mirasvit aheadworks amasty and others alike? |
|
@seansan If you have the layout cache enabled then it will significantly reduce the amount of cache storage used (and data written). That is all, but in cases where cache storage is valuable (such as in-memory caches like Redis, Memcache, etc.) it is quite important. |
|
From the code I think there can happen collisions if the same update with different handles is used |
|
It is the full XML that is hashed, not just a list so the only possibility for collision is in the sha1 space which I think is pretty reasonable. |
drobinson
approved these changes
Sep 30, 2016
LeeSaferite
approved these changes
Oct 16, 2016
|
Merged 1.9.2.4 into 1.9.3.0 |
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Dec 6, 2017
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 28, 2018
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Mar 20, 2018
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Jul 17, 2018
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Sep 19, 2018
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 14, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Apr 1, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As announced a while back and made public first here: https://gist.github.com/colinmollenhour/14ed23d029e5b991a3e31ad1fe0841d4
I've been using this in production for months now with no issues. Massive cache storage savings.