Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mage::log() not working on new Magento update (1.9.4.1) #646

Closed
sreichel opened this issue Apr 2, 2019 · 7 comments · Fixed by #652
Closed

Mage::log() not working on new Magento update (1.9.4.1) #646

sreichel opened this issue Apr 2, 2019 · 7 comments · Fixed by #652
Labels
bug Mage.php Relates to app/Mage.php

Comments

@sreichel
Copy link
Contributor

sreichel commented Apr 2, 2019

Log seems broken, when log files does not exist .... https://magento.stackexchange.com/a/268396/46249

Hope for next official update?
@sreichel sreichel mentioned this issue Apr 2, 2019
Merged
@Flyingmana
Copy link
Contributor

Iam aware of this Issue, I guess we will accept a community provided fix for this Issue after the merge

edannenberg added a commit to edannenberg/magento-lts that referenced this issue Apr 2, 2019
@edannenberg
Zend_Validate_File_Extension::isValid() fails if filename doesn't exist
f8accab 
The purpose of the class is to check if a given filename has an
expected file extension. It shouldn't matter if the file actually
exists or not, the method only operates on the given string.

refs: OpenMage#646
@edannenberg edannenberg mentioned this issue Apr 2, 2019
Closed
edannenberg added a commit to edannenberg/magento-lts that referenced this issue Apr 4, 2019
@edannenberg
Zend_Validate_File_Extension::isValid() fails if filename doesn't exist
5dfcf3c 
The purpose of the class is to check if a given filename has an
expected file extension. It shouldn't matter if the file actually
exists or not, the method only operates on the given string.

Also fixes Zend_Validate_File_ExcludeExtension which has the same
issue.

refs: OpenMage#646
@sreichel sreichel mentioned this issue Apr 4, 2019
Closed
@colinmollenhour colinmollenhour mentioned this issue Apr 5, 2019
Merged
@themew
Copy link

themew commented Apr 15, 2019

Fixed here > https://gist.github.com/piotrekkaminski/0596cae2d25bf467edbd3d3f03ab9f8f
but nothing from Magento about a V2 patch.

@seansan
Copy link
Contributor

seansan commented May 10, 2019

Hi, was this fixed maybe and pushed to 4.x? (having this probem too now)

@themew
Copy link

themew commented May 16, 2019

Hi, was this fixed maybe and pushed to 4.x? (having this probem too now)

The patch works or you can manually edit the app/Mage.php file

@colinmollenhour
Copy link
Member

Can someone else approve one or more of #648, #652 or #670? All three are correct in my opinion, but we need at least one of them to fix this issue.

@colinmollenhour
Copy link
Member

Merged #670.

@aadmathijssen
Copy link

This issue has been fixed in CE 1.9.4.2 with exactly the same changes as in #670.

@sreichel sreichel added bug fixed Mage.php Relates to app/Mage.php labels Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Mage.php Relates to app/Mage.php
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only validate file extension once, remove unnecessary use of Zend_Val… colinmollenhour/magento-lts
6 participants
@colinmollenhour @Flyingmana @seansan @aadmathijssen @sreichel @themew