Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong labels in translation file Mage_Catalog #27

Closed
tmotyl opened this issue Jul 9, 2015 · 1 comment
Closed

Wrong labels in translation file Mage_Catalog #27

tmotyl opened this issue Jul 9, 2015 · 1 comment
Labels
bug translations Relates to app/locale

Comments

@tmotyl
Copy link
Contributor

tmotyl commented Jul 9, 2015

The file
https://github.com/OpenMage/magento-lts/blob/1.9.1/app/locale/en_US/Mage_Catalog.csv#L482

contains label "Please specify the product's option(s)" which is wrong. It should be "Please specify the product's option(s)".
Also all other languages are affected. This bug prevents magento from translating this message and it always appear in english.

Probably sb just copied the label from
https://github.com/OpenMage/magento-lts/blob/1.9.1/app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php#L689

where slash is added to escape single quote in php.

This message appear eg. when you try to add to cart configurable product from wishlist. But the product is not yet configured
@tmotyl
Copy link
Contributor Author

tmotyl commented Oct 8, 2015

actually the problem is much bigger.
there are over 100 wrong places in translation files....

tmotyl added a commit to macopedia/magento-lts that referenced this issue Oct 8, 2015
@tmotyl
Unescape single quotes in Magento translation files
9964cad 
Signle quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
@tmotyl tmotyl mentioned this issue Oct 8, 2015
Merged
Flyingmana pushed a commit to Flyingmana/magento-lts that referenced this issue Oct 18, 2016
@tmotyl @Flyingmana
Unescape single quotes in Magento translation files
e3131a9 
Signle quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not
translated.

Fixes OpenMage#27
@tomekjordan tomekjordan mentioned this issue Feb 22, 2017
Closed
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Nov 27, 2017
@tmotyl @edannenberg
[bug#46] Unescape single quotes in Magento translation files
4d59d63 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Dec 6, 2017
@tmotyl @edannenberg
[bug-OpenMage#46] Escaped single quotes in Magento translation files
ca79608 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Feb 28, 2018
@tmotyl @edannenberg
[bug-OpenMage#46] Escaped single quotes in Magento translation files
95c8a5c 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Jul 17, 2018
@tmotyl @edannenberg
[bug-OpenMage#46] Escaped single quotes in Magento translation files
a9234ee 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Sep 19, 2018
@tmotyl @edannenberg
[bug-OpenMage#46] Escaped single quotes in Magento translation files
db8ffa1 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Feb 14, 2019
@tmotyl @edannenberg
[bug-OpenMage#46] Escaped single quotes in Magento translation files
9dd2974 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Apr 1, 2019
@tmotyl @edannenberg
[bug-OpenMage#46] Escaped single quotes in Magento translation files
129afbe 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Aug 22, 2019
@tmotyl @edannenberg
[bug-OpenMage#46] Escaped single quotes in Magento translation files
da795c2 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Oct 25, 2019
@tmotyl @edannenberg
[bug-OpenMage#46] Escaped single quotes in Magento translation files
8b6eb99 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
@sreichel sreichel added bug fixed translations Relates to app/locale labels Jun 27, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Aug 20, 2020
@tmotyl @edannenberg
[bug-OpenMage#46] Escaped single quotes in Magento translation files
b1e66b4 
Single quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage#27
randallelliott714 added a commit to randallelliott714/magento that referenced this issue Oct 18, 2022
@randallelliott714
Unescape single quotes in Magento translation files
0f235c6 
Signle quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.

Fixes OpenMage/magento-lts#27
@matteotestoni matteotestoni mentioned this issue Mar 16, 2023
Closed
@andyt andyt mentioned this issue Apr 24, 2023
Closed
@OnyXxL OnyXxL mentioned this issue Feb 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug translations Relates to app/locale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmotyl @sreichel