Test - Issue 481 - Green Builds Showing Despite Test Failures #487
Conversation
| if [ "$rc" -ne 0 ]; then | ||
| echo "ERROR: Failure while driving npm install on plugin. rc: ${rc}." | ||
| if [ "$failure" = "true" ]; then | ||
| echo "ERROR: Failure while driving npm install on plugin." |
There was a problem hiding this comment.
Based on the way this script works now, this error message does not seem accurate. Please update.
There was a problem hiding this comment.
Updated with following comment: "ERROR: Failure occurred while running the tests."
There was a problem hiding this comment.
One other thought, do you think it would be beneficial to differentiate between failures in the "build", "initialization" and "test" steps of the script? If so, it is not necessary for this PR, but may be good to open an enhancement issue.
There was a problem hiding this comment.
It is not required to differentiate between failures in the build, initialization and test steps of the script. In exec.sh these steps are differentiated by the type. For each type we will be checking for failure and if a failure occured, that step will be exited with exit code -1 and error will be shown in the corresponding step in GHA. Hence no differentiation required.
| @@ -40,6 +43,7 @@ main() { | |||
| npm run build | |||
| npm run compile | |||
| vsce package | |||
| updateExitStatus | |||
| else | |||
|
|
|||
| #Initialisation step | |||
There was a problem hiding this comment.
should there be a call to updateExitStatus in the "Initialisation step" section?
There was a problem hiding this comment.
Opened an issue: #504
| if [ "$rc" -ne 0 ]; then | ||
| echo "ERROR: Failure while driving npm install on plugin. rc: ${rc}." | ||
| if [ "$failure" = "true" ]; then | ||
| echo "ERROR: Failure while driving npm install on plugin." |
There was a problem hiding this comment.
One other thought, do you think it would be beneficial to differentiate between failures in the "build", "initialization" and "test" steps of the script? If so, it is not necessary for this PR, but may be good to open an enhancement issue.
|
Test PR created for #505. |
Fixes #481
Added method to fetch the status of previous command and update a boolean flag to see if the build is a failure or not.