Removed use of # from the PR number

[vaisakhkannan]

Fixes #1244

Removed use of Special character # from the PR number for the slack message

With the latest changes in this PR there is no issue with the text from GitHub (title of the PR), and it include '#' or '@' characters without any problems.

[mrglavas]

Looks good. Thanks.

[turkeylurkey]

In the screen shot you provide in this pull request you show sample text that reads "#749." It is not replaced with "private channel" possibly because our instance of Slack does not have a channel named 749 whereas it did seem to have a channel named "777" or some other number. So this example does not seem to prove there is no problem.

Can you try a test where you use a string from a github issue you open or perhaps you use your own dummy string that reads the same as a known existing channel?

[anusreelakshmi934]

@vaisakhkannan Can we completely avoid using the # sign? As Paul mentioned, there's a chance that another PR number might have a channel with that format, which could cause an issue.

[vaisakhkannan]

@anusreelakshmi934 , @turkeylurkey
I was able to reproduce the issue in my fork runs that you mentioned regarding the existing channel name (e.g., issue number 778).

I found a fix today and tested it with the latest changes, and it is working as expected for the '#' case. However, for the other special character '@' case, I couldn't identify the problem. I have added Slack IDs starting with '@' in the dummy PRs, and they are displaying correctly as expected. Below is the screenshot including the fix of # usages.

[mrglavas]

Approving again.

[anusreelakshmi934]

looks good