-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the retrieval of the local LSP4IJ path. #1247
Fixed the retrieval of the local LSP4IJ path. #1247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anusreelakshmi934 It occurred to me that there's an unzip step in our build: https://github.com/OpenLiberty/liberty-tools-intellij/blob/main/.github/workflows/build.yaml that seems no longer necessary with these changes. We should clean that up to avoid any confusion.
Yes @mrglavas . I have cleaned up the code. In this run, the 24.0.9 build fails because it lacks the unzip step, preventing it from retrieving the |
@anusreelakshmi934 I believe in our team discussion earlier today we agreed that the unzip step should be restored to allow the 24.0.9 build to run. We also agreed that a comment be added to document that the unzip step is required for compatibility with the 24.0.9 build. |
This reverts commit 739656b.
I have added a comment above the unzip step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fixes #1242