-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new test case for Run/Debug Configurations #1239
Open
turkeylurkey
wants to merge
4
commits into
OpenLiberty:main
Choose a base branch
from
turkeylurkey:issue-1236
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaisakhkannan
requested changes
Jan 23, 2025
src/test/java/io/openliberty/tools/intellij/it/MavenSingleModMPCfgProjectTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/openliberty/tools/intellij/it/MavenSingleModMPCfgProjectTest.java
Show resolved
Hide resolved
…a Run/Debug config Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
abd4c97
to
2640e28
Compare
vaisakhkannan
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me , Thanks
anusreelakshmi934
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to trigger the bug the Liberty project must not have been loaded by a previous test case. Also the Liberty dashboard must not have been opened since IntelliJ started up. The state of the project will even be persisted if you close the workspace and go back to the Welcome screen and open a different project or the same project.
So this test case copies an existing project into a new location so that the project will be treated as unique. This is similar to the
GradleSingleModMPSIDProjectTest
project which makes a copy. This test case also does not open the Liberty dashboard like all the other UI test cases do. Finally there is just one test in this environment. I tested that it fails for 24.0.12 but it passes with the fix for #1202.I updated some comments in
GradleSingleModMPSIDProjectTest
in order to clarify where some of the names come from i.e. they must match.Fixes #1236