Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IR projector #432

Closed
wants to merge 10 commits into from
Closed

IR projector #432

wants to merge 10 commits into from

Conversation

zhumxcq
Copy link

@zhumxcq zhumxcq commented Jan 12, 2015

Able to change IR projector intensity, wait I don't know what I'm doing -__- I just want to make a new function to change IR projector intensity...

floe and others added 10 commits October 15, 2011 03:09
Signed-off-by: Florian Echtler <floe@butterbrot.org>
Signed-off-by: Florian Echtler <floe@butterbrot.org>
Signed-off-by: Florian Echtler <floe@butterbrot.org>
Signed-off-by: Florian Echtler <floe@butterbrot.org>
Signed-off-by: Benn Snyder <benn.snyder@gmail.com>
Signed-off-by: Benn Snyder <benn.snyder@gmail.com>
@piedar
Copy link
Contributor

piedar commented Jan 12, 2015

I don't know what IR intensity means and there's no reference in the protocol documentation. I'm closing this pull request because it doesn't make sense to merge debian into master.

@piedar piedar closed this Jan 12, 2015
@zhumxcq
Copy link
Author

zhumxcq commented Jan 12, 2015

Hey its cmd 0x0015, I'm not sure how to do a pull request properly, but
basically I want to add a function like
freenect_set_ir_brightness(uint8_t brightness) to the library header.

On 15-01-12 10:22 AM, Benn Snyder wrote:

I don't know what IR intensity means and there's no reference in the
protocol documentation
http://openkinect.org/wiki/Protocol_Documentation. I'm closing this
pull request because it doesn't make sense to merge |debian| into
|master|.


Reply to this email directly or view it on GitHub
#432 (comment).

@piedar
Copy link
Contributor

piedar commented Jan 12, 2015

OK, I see it now. I created #433.

@zhumxcq
Copy link
Author

zhumxcq commented Jan 13, 2015

Hey,

Are you the package maintainer? If so, find attached the .patch file
that adds the feature. There may be need to do some error checking or
function printing though.

Regards,
Meng Xi Zhu

On 15-01-12 11:03 AM, Benn Snyder wrote:

OK, I see it now. I created #433
#433.


Reply to this email directly or view it on GitHub
#432 (comment).

@piedar
Copy link
Contributor

piedar commented Jan 21, 2015

Github doesn't support email attachments, so I think it ate your patch. If you'd be so kind to paste it in a comment over at #433, I can schedule it for merge. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants