-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python wrapper updates #397
Conversation
This fixes link errors on Mac OS X. Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
This avoids segfaults due to improper use of *Ptr objects like CtxPtr. Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
e241863
to
4e489af
Compare
What's the benefit of treating freenect.c as binary? |
Pretty much any change in freenect.pyx produces a huge change in
|
True. It might be even better to remove freenect.c and have a build dep on cython (note to self). |
Python wrapper updates Reviewed-by: Benn Snyder <benn.snyder@gmail.com>
Not particularly ideal for people without Cython, though. I usually try to
|
Here are a number of minor changes I've made to the Python wrapper over the past few years. I've recently rebased against today's master branch, and verified that the changes are working.
Changes:
*Ptr
classes from being created from Python by accident