Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python wrapper updates #397

Merged
merged 6 commits into from
Sep 2, 2014
Merged

Python wrapper updates #397

merged 6 commits into from
Sep 2, 2014

Conversation

nneonneo
Copy link
Contributor

@nneonneo nneonneo commented Jul 3, 2014

Here are a number of minor changes I've made to the Python wrapper over the past few years. I've recently rebased against today's master branch, and verified that the changes are working.

Changes:

  • Fix link error on OS X
  • Prevent invalid *Ptr classes from being created from Python by accident
  • Gracefully handle non-standard depth/video modes, and handle 10-bit IR mode properly
  • .gitignore/.gitattributes changes for happier development
  • Build wrapper with Cython 0.20 to pick up the latest Cython fixes

nneonneo added 6 commits July 2, 2014 20:34
This fixes link errors on Mac OS X.

Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
This avoids segfaults due to improper use of *Ptr objects like CtxPtr.

Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
@piedar piedar added this to the v0.5.0 milestone Jul 3, 2014
@piedar piedar modified the milestones: v0.5.1, v0.5.0 Jul 15, 2014
@piedar piedar mentioned this pull request Sep 1, 2014
@piedar piedar force-pushed the master branch 2 times, most recently from e241863 to 4e489af Compare September 1, 2014 21:07
@piedar
Copy link
Contributor

piedar commented Sep 1, 2014

What's the benefit of treating freenect.c as binary?

@nneonneo
Copy link
Contributor Author

nneonneo commented Sep 1, 2014

Pretty much any change in freenect.pyx produces a huge change in
freenect.c, which pollutes the diff unnecessarily.
On Sep 1, 2014 5:19 PM, "Benn Snyder" notifications@github.com wrote:

What's the benefit of treating freenect.c as binary?


Reply to this email directly or view it on GitHub
#397 (comment)
.

@piedar
Copy link
Contributor

piedar commented Sep 2, 2014

True. It might be even better to remove freenect.c and have a build dep on cython (note to self).

@piedar piedar changed the title Changes to the Python wrapper Python wrapper updates Sep 2, 2014
piedar added a commit that referenced this pull request Sep 2, 2014
Python wrapper updates

Reviewed-by: Benn Snyder <benn.snyder@gmail.com>
@piedar piedar merged commit 6e04f75 into OpenKinect:master Sep 2, 2014
@nneonneo
Copy link
Contributor Author

nneonneo commented Sep 2, 2014

Not particularly ideal for people without Cython, though. I usually try to
avoid build requirements if possible.
On Sep 2, 2014 12:47 AM, "Benn Snyder" notifications@github.com wrote:

True. It might be even better to remove freenect.c and have a build dep on
cython (note to self).


Reply to this email directly or view it on GitHub
#397 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants