Bugfix for multiple K4W or 1473 devices needing keep_alive. #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y PID fails when multiple identical devices are on the system. This PR uses libusb_get_parent and lib_usb_get_bus_number to get the correct audio device for a camera. PR is backwards compatible with older versions of libusb. Signed-off-by: Theodore Watson <theo@openframeworks.cc> (ofTheo)
piedar
added a commit
that referenced
this pull request
Apr 25, 2014
Bugfix for multiple K4W or 1473 devices needing keep_alive. Reviewed-by: Benn Snyder <benn.snyder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening by PID fails when multiple identical devices are on the system ( i.e.: if there are two Kinect 1473 libusb_open_device_with_vid_pid has no way to know which audio device to open.
This PR uses the newer
libusb_get_parentandlib_usb_get_bus_numberto get the correct audio device for a camera.PR is backwards compatible with older versions of libusb so it only applies the newer method if libusb >= 1.0.18 is detected. At a later date we can assume 1.0.18 or higher and remove the keep_alive.c files.
Signed-off-by: Theodore Watson theo@openframeworks.cc (ofTheo)