Fix for disconnecting 1473 and K4W devices. Closes #340

[ofTheo]

This fixes a known issue for OS X users where the device re-enumerates within a small time period and causes a freeze.

This PR detects 1473 devices and K4W devices and sets the LED state to solid red.
It seems that in newer 1473 devices and 1473 devices with firmware updated by an Xbox the device will re-enumerate unless the LED is set.

The code is fairly compact, but it needs testing on a K4W device.
@wizgrav - would be great if you could pull and confirm if this sets K4W LED to red as well.

Most of this code is adapted from Drew Fisher's ( @zarvox ) proof of concept tilt code.
Note: it doesn't require the audio firmware to be flashed.

Closes #340 and addresses #316.

Signed-off-by: Theodore Watson theo@openframeworks.cc (ofTheo)

[wizgrav]

awesome, I'll have a chance to test a k4w in the weekend. would xtion support also make sense?

[ofTheo]

I sort of feel for now that sticking with the Kinect devices is a better way to go.
Once we have full parity across k4w, 1473 and 1414 - then it could be a good time to look at expanding.

But getting that parity first would be amazing! :)
I also have a K4W device coming in a couple of days.

I got @zarvox's Tilt and LED for 1473 working really well today and integrated into libfreenect with audio firmware loading from memory:
openframeworks/openFrameworks#2778

Once I have the K4W device I'll test for compatibility and submit a PR to this repo.

It seems really close!
This PR though is really needed for OS X and 1473.

[ofTheo]

@wizgrav - I got a K4W device and had to do a few fixes but now its working great!

I made a more comprehensive PR ( #362 ) which also allows for the motor/led/accel control on K4W and better checking for device type.

That PR also has the keep_alive code which fixes #340 and #316.
So I am going to close this PR and encourage @zarvox to merge #362 :)

If you are able to test #362 on Win or Nix it would be most appreciated.
Thanks!!
Theo

[tufekoa]

Hi of Theo, Thanks for your work on this issue I just got the Kinect 1473 with the same problem. I was just wondering how to use your code,Where in libfreenect do we have to make the changes. I'm sorry but I am really a bit new to this but am on it night and day. Cheers!

[collinalexbell]

bump tufekoa, I am having the same troubles

[tufekoa]

I suggest you get a 1414 model. There are reburbished models for sale online. I spent a lot of time on this in pure waste. Cheers