freenect_flag should be a real flags enum (raw registers should be coded differently) #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Xiao <brx@cs.cmu.edu>
piedar
added a commit
that referenced
this pull request
Nov 16, 2013
freenect_flag should be a real flags enum (raw registers should be coded differently) (@nneonneo) Reviewed-by: Benn Snyder <benn.snyder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
freenect_flagto be a real flags enum, i.e. one where you can set individual bits in the enum (could be used to set settings in bulk in the future, for example, or to quickly query the set of active flags). It is a fix for issue #341.