Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop libusbemu and use native libusb 1.0.9 Windows support. #363

Closed
ofTheo opened this issue Feb 2, 2014 · 4 comments
Closed

Drop libusbemu and use native libusb 1.0.9 Windows support. #363

ofTheo opened this issue Feb 2, 2014 · 4 comments
Milestone

Comments

@ofTheo
Copy link
Contributor

ofTheo commented Feb 2, 2014

As of libusb 1.0.9, libusb supports Windows natively.
We should remove calls to libusbemu and use the same calls as we do on linux / os x.

BUILD_AUDIO is currently broken on Windows because libusbemu does not emulate all libusb functions. ( libusb_get_device an example of one ).

See:
http://www.libusb.org/wiki/windows_backend

I am happy to build the libs and submit a PR - just wanted to see if there was any objections or reasons why this has not already been done.

Theo

@JoshBlake
Copy link
Member

Yes, upgrading libusb would be fine.

Note though: Don't use libusb.org anymore. Use libusb.info. The libusb team
doesn't control libusb.org and the person who controls it isn't associated
with the project anymore.

See also migration and update notes about the libusbx and libusb merge and
updated URLs for code/web sites that I forwarded to the list on Jan 25th.

Josh

On Sun, Feb 2, 2014 at 3:50 PM, Theodore Watson notifications@github.comwrote:

As of libusb 1.0.9, libusb supports Windows natively.
We should remove calls to libusbemu and use the same calls as we do on
linux / os x.

BUILD_AUDIO is currently broken on Windows because libusbemu does not
emulate all libusb functions. ( libusb_get_device an example of one ).

See:
http://www.libusb.org/wiki/windows_backend

I am happy to build the libs and submit a PR - just wanted to see if there
was any objections or reasons why this has not already been done.

Theo

Reply to this email directly or view it on GitHubhttps://github.com//issues/363
.

@piedar
Copy link
Contributor

piedar commented Feb 3, 2014

The same idea has occurred to me, but I never looked into it. I say go for it!

@piedar
Copy link
Contributor

piedar commented Feb 4, 2014

I did a little poking around with VS 2012. If you run into compile errors in usb_libusb10.c about failing to convert iso_callback, modify the function signature like so:

static void LIBUSB_CALL iso_callback(struct libusb_transfer *xfer)

@piedar piedar added this to the v0.5.0 milestone Feb 16, 2014
@piedar piedar modified the milestones: v0.4.2, v0.5.0 Apr 15, 2014
@piedar
Copy link
Contributor

piedar commented Apr 15, 2014

This will be addressed in #383.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants