fix Bau091A:IsAckRequired for Broadcasts

OpenKNX · Dec 23, 2024 · c1588e1 · c1588e1
1 parent 919b8e3
commit c1588e1
Showing 1 changed file with 18 additions and 10 deletions.
diff --git a/src/knx/bau091A.cpp b/src/knx/bau091A.cpp
@@ -175,17 +175,25 @@ TPAckType Bau091A::isAckRequired(uint16_t address, bool isGrpAddr)
     {
         // ACK for broadcasts
         if (address == 0)
+        {
             ack = TPAckType::AckReqAck;
-
-        if(lcconfig & LCCONFIG::GROUP_IACK_ROUT)
-            // is group address in filter table? ACK if yes, No if not
-            if(_netLayer.isRoutedGroupAddress(address, 1))
-                ack = TPAckType::AckReqAck;
-            else
-                ack = TPAckType::AckReqNone;
+        }
         else
-            // all are ACKED
-            ack = TPAckType::AckReqAck;
+        {
+            if(lcconfig & LCCONFIG::GROUP_IACK_ROUT)
+            {
+                // is group address in filter table? ACK if yes, No if not
+                if(_netLayer.isRoutedGroupAddress(address, 1))
+                    ack = TPAckType::AckReqAck;
+                else
+                    ack = TPAckType::AckReqNone;
+            }
+            else
+            {
+                // all are ACKED
+                ack = TPAckType::AckReqAck;
+            }
+        }
 #ifdef KNX_TUNNELING
         if(_dlLayerPrimary.isSentToTunnel(address, isGrpAddr))
             ack = TPAckType::AckReqAck;
@@ -209,7 +217,7 @@ TPAckType Bau091A::isAckRequired(uint16_t address, bool isGrpAddr)
 #endif
 
     }
-
+    printf("ack %u\n", ack);
     return ack;
 }