Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModifyAttribute support to the server #609

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

PeterHamilton
Copy link
Contributor

This change adds ModifyAttribute operation support to the PyKMIP server, including additional attribute policy functionality to check for certain attribute characteristics that preclude ModifyAttribute operation functionality. New unit tests have been added to cover these changes.

Partially implements #547

This change adds ModifyAttribute operation support to the PyKMIP
server, including additional attribute policy functionality to
check for certain attribute characteristics that preclude
ModifyAttribute operation functionality. New unit tests have been
added to cover these changes.

Partially implements #547
@PeterHamilton PeterHamilton force-pushed the feat/add-modify-attribute-to-server branch from a28116e to 577933e Compare December 9, 2019 14:59
@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b4855be). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #609   +/-   ##
=========================================
  Coverage          ?   96.58%           
=========================================
  Files             ?       79           
  Lines             ?    16870           
  Branches          ?        0           
=========================================
  Hits              ?    16294           
  Misses            ?      576           
  Partials          ?        0
Impacted Files Coverage Δ
kmip/services/server/engine.py 99.38% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4855be...577933e. Read the comment docs.

@PeterHamilton PeterHamilton merged commit 4e59a8a into master Dec 9, 2019
@PeterHamilton PeterHamilton deleted the feat/add-modify-attribute-to-server branch December 9, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants