Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetAttribute support to the server #606

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

PeterHamilton
Copy link
Contributor

This change adds SetAttribute operation support to the PyKMIP server, including additional attribute policy functionality to check for certain attribute characteristics that preclude SetAttribute operation functionality. Specifically, the operation cannot set the value of any multivalued attribute nor the value of any attribute not modifiable by the client. New unit tests have been added to cover these changes.

Partially implements #547

This change adds SetAttribute operation support to the PyKMIP
server, including additional attribute policy functionality to
check for certain attribute characteristics that preclude
SetAttribute operation functionality. Specifically, the operation
cannot set the value of any multivalued attribute nor the value
of any attribute not modifiable by the client. New unit tests
have been added to cover these changes.

Partially implements #547
@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e313731). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #606   +/-   ##
=========================================
  Coverage          ?   96.54%           
=========================================
  Files             ?       79           
  Lines             ?    16709           
  Branches          ?        0           
=========================================
  Hits              ?    16132           
  Misses            ?      577           
  Partials          ?        0
Impacted Files Coverage Δ
kmip/services/server/policy.py 100% <100%> (ø)
kmip/services/server/engine.py 99.22% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e313731...a080e8b. Read the comment docs.

@PeterHamilton PeterHamilton merged commit 3be2191 into master Nov 22, 2019
@PeterHamilton PeterHamilton deleted the feat/add-set-attribute-to-server branch November 22, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants