Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeleteAttribute support to the server #598

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

PeterHamilton
Copy link
Contributor

This change adds DeleteAttribute operation support to the PyKMIP server, supporting functionality unique to KMIP 1.0 - 1.4 and the newer KMIP 2.0. Due to the current list of attributes supported by the server, only multivalued attributes can currently be deleted from a stored KMIP object. Over a dozen unit tests have been added to verify the functionality of the new additions.

Partially implements #547

@PeterHamilton PeterHamilton added feature testing server database Features and updates pertaining to the server database labels Nov 8, 2019
@PeterHamilton PeterHamilton added this to the 0.10 Release milestone Nov 8, 2019
This change adds DeleteAttribute operation support to the PyKMIP
server, supporting functionality unique to KMIP 1.0 - 1.4 and the
newer KMIP 2.0. Due to the current list of attributes supported
by the server, only multivalued attributes can currently be
deleted from a stored KMIP object. Over a dozen unit tests have
been added to verify the functionality of the new additions.

Partially implements #547
@PeterHamilton PeterHamilton force-pushed the feat/add-delete-attribute-to-server branch from 3a7be9d to 178220f Compare November 8, 2019 23:09
@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #598 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
+ Coverage   96.42%   96.44%   +0.02%     
==========================================
  Files          76       76              
  Lines       16165    16241      +76     
==========================================
+ Hits        15587    15664      +77     
+ Misses        578      577       -1
Impacted Files Coverage Δ
kmip/pie/objects.py 100% <ø> (ø) ⬆️
kmip/services/server/policy.py 100% <100%> (ø) ⬆️
kmip/services/server/engine.py 99.29% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48aff7...178220f. Read the comment docs.

@PeterHamilton PeterHamilton merged commit 676aaf5 into master Nov 8, 2019
@PeterHamilton PeterHamilton deleted the feat/add-delete-attribute-to-server branch November 8, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Features and updates pertaining to the server database feature server testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants