Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the DeleteAttribute request and response payloads #597

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

PeterHamilton
Copy link
Contributor

This change adds support for the DeleteAttribute operation in the form of request and response payload structures. These will be used in a future updates by the client and server to fully support the DeleteAttribute operation. A new unit test suite has been added to cover the new changes.

Partially implements #547

This change adds support for the DeleteAttribute operation in the
form of request and response payload structures. These will be used
in a future updates by the client and server to fully support the
DeleteAttribute operation. A new unit test suite has been added to
cover the new changes.

Partially implements #547
@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@616e683). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #597   +/-   ##
=========================================
  Coverage          ?   96.42%           
=========================================
  Files             ?       76           
  Lines             ?    16165           
  Branches          ?        0           
=========================================
  Hits              ?    15587           
  Misses            ?      578           
  Partials          ?        0
Impacted Files Coverage Δ
kmip/core/messages/payloads/__init__.py 100% <100%> (ø)
kmip/core/messages/payloads/delete_attribute.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616e683...97869b0. Read the comment docs.

@PeterHamilton PeterHamilton merged commit e48aff7 into master Nov 1, 2019
@PeterHamilton PeterHamilton deleted the feat/add-delete-attribute-payloads branch November 1, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants