Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFMM Functionality in Mod Manager. #627

Closed
wants to merge 5 commits into from
Closed

Conversation

TopazTK
Copy link
Collaborator

@TopazTK TopazTK commented Jul 17, 2022

Build_From_MM was a Python program used which allowed for Mod Manager mods to be used in the PC ports.
This PR basically takes in everything it can do and implements it to Mod Manager itself so that we don't have to fiddle around.

What it does:

  • Allowing the Mod Manager to be set up for the PC ports.
  • Building for OpenKH/PS2/PC specifically (Depending on what was declared in the wizard.)
  • Extraction, Patching [Regular and "Fast"], and Backup of the EGS games.
  • Restoration of the backups made with MM.

What it adds to "mod.yml":

  • The "platform" tag to specifically state if a file is for a specific platform [pc, ps2, both] (Assumed "both" if not present.)
  • The "package" tag to use with PC only. Tells a file where exactly to be patched to [kh2_* first, second, third, fourth, fifth, sixth] (Ignored on non-PC platforms. Assumed "kh2_first" if not present.)

From the tests made, it works surprisingly well. And it is able to patch the game ridiculously fast and is compliant with everything OpenKH tries to accomplish. Some of the "OpenKh.Egs" functions were implemented to MM separately as trying to use them would mean there would be no indication as to what was done.

I know the code is kinda messy, and there are still some things I have to do, I have to tidy up the code, add kh2pcpatch support, make sure shit works with everything etc. But this update was heavily requested by the majority of the modding community, and I had to deliver.

@TopazTK
Copy link
Collaborator Author

TopazTK commented Jul 18, 2022

Closing due to the merge of #625, which makes this PR broken and in minimal necessity.
The YAML edits make to this can be done to #625 with minimal effort should they be necessary.

@TopazTK TopazTK closed this Jul 18, 2022
@MainMemory
Copy link
Collaborator

MainMemory commented Jul 18, 2022

I strongly disagree with the closing of this PR

@Delta-473
Copy link
Collaborator

This pr adds a base to support patching of the other games on pc.

@TopazTK
Copy link
Collaborator Author

TopazTK commented Jul 18, 2022

Reopened due to immense backlash. <3

@TopazTK TopazTK reopened this Jul 18, 2022
@shananas
Copy link
Collaborator

shananas commented Jul 18, 2022

This PR would at least help the Rando community a lot as we already have to use a second program to patch our seeds. Yes the mod loader would be preferred but this implements extraction in ModsManager and the ability to make 1 mod for both PC and Emulator with the tag feature.
Dee-Ayy already did a good writeup on the Mod Manager Improvements about why tags are needed because of region and file differences between PC and Emulator so ill add 1 thing.
If you want to use the type: internal method for a.fm or a.us files the mod will only be compatible with emulator or PC respectively.
being able to tell MM ignore a.fm/a.us so the build does not fail allows for provided less vanilla files and use of type: internal in 1 mod for both PC an emulator

@TopazTK
Copy link
Collaborator Author

TopazTK commented Jul 19, 2022

Closing due to patching "not fitting into OpenKH", not to be opened again.

@TopazTK TopazTK closed this Jul 19, 2022
@OpenKH OpenKH locked as off-topic and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants