Refactored WiFi configuration window #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Window now changes state based on the WindowState - removed JoinPopWindow, WiFiPopoverView, WiFiPopupWindow, and PrefsViewWiFiInfoModal in favor a more simplified, single file WiFiConfigWindow. - Removed add button from `.viewCredentialsWiFi` window and renamed edit to view
|
This should also fix part of #66 in regards to |
Goshin
reviewed
Aug 10, 2020
Goshin
approved these changes
Aug 10, 2020
|
Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone!
I hope everyone is doing great! I just came with another update to make our lives a bit easier, at least in regards to duplicated classes for the same idea, WiFi windows!
This pull requests removes
JoinPopWindow,WiFiPopoverView,WiFiPopupWindow, andPrefsViewWiFiInfoModalin favor of a simplified classWiFiConfigWindow. The initial constructor without any arguments creates aJoinPopWindow. I hope this reduces the number of places to make changes, i.e. adding more security options.I also renamed the
editbutton fromPrefsSavedNetworksViewtoviewsince you can only view the information as of now. Maybe in the future once more implementations of security are available, we can allow users to change their saved passwords, but as of now you can only view or removed saved networks.