Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard closing, Fix #382 #383

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Guard closing, Fix #382 #383

merged 4 commits into from
Jan 11, 2022

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Jan 7, 2022

This PR introduces a best-effort guarding around the Map::close process.

The close() process will wait up to 2 seconds before continuing. This can prevent a number of problems.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

30.7% 30.7% Coverage
1.5% 1.5% Duplication

@minborg minborg merged commit b817e13 into develop Jan 11, 2022
@minborg minborg deleted the guard_closing branch January 11, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobAustin RobAustin RobAustin approved these changes

@peter-lawrey peter-lawrey Awaiting requested review from peter-lawrey

@glukos glukos Awaiting requested review from glukos

@JerryShea JerryShea Awaiting requested review from JerryShea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minborg @RobAustin