Skip to content

Commit

Permalink
allows setting startupProbe on deployment (#88)
Browse files Browse the repository at this point in the history
  • Loading branch information
whereismyjetpack authored Nov 4, 2024
1 parent 453a478 commit 20b7f27
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/application-core/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 4.2.3
version: 4.2.4

maintainers:
- name: Dominic DePasquale
6 changes: 6 additions & 0 deletions charts/application-core/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ spec:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
{{- if .Values.startupProbe }}
{{- with .Values.startupProbe }}
startupProbe:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
{{- if .Values.livenessProbe }}
{{- with .Values.livenessProbe }}
livenessProbe:
Expand Down
11 changes: 9 additions & 2 deletions charts/application-core/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ configMap:

command: []

env:
[]
env: []
# - name: FOO
# value: BAR
# - name: BAZ
Expand Down Expand Up @@ -139,6 +138,14 @@ externalSecret:
deletionPolicy: Retain
template: {}

startupProbe: {}
# httpGet:
# path: /api/v1/healthcheck
# port: http
# failureThreshold: 30
# periodSeconds: 10


livenessProbe:
httpGet:
path: /
Expand Down

0 comments on commit 20b7f27

Please sign in to comment.