Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windows from CI #8

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Remove windows from CI #8

merged 5 commits into from
Dec 12, 2024

Conversation

chinwobble
Copy link
Contributor

@chinwobble chinwobble commented Dec 10, 2024

  • Remove windows from CI build matrix
  • Fix the documentation to list all dependencies

I've tried to remove ninja-build dependency but it doesn't integrate well with IDE.
The cmake ninja multi configuration generator solves a lot of problems like creating separate Debug and Release builds, integrates better with vscode plugin.
I've deleted the section for lib deflate because that is no longer required, vcpkg will automatically build so that user won't need to install it system wide.

https://marketplace.visualstudio.com/items?itemName=ms-vscode.cmake-tools

I've tested in this docker container.

FROM ubuntu:latest


WORKDIR /app
COPY . .
RUN apt update && apt install cmake make -y
RUN apt install git ninja-build g++ curl zip unzip tar pkg-config -y
RUN apt install libisal-dev -y

RUN make

This makes it easier to test for arm64 locally.

docker build -t fastplong --platform linux/amd64 -f Dockerfile .
docker build -t fastplong --platform linux/arm64 -f Dockerfile .

@sfchen
Copy link
Member

sfchen commented Dec 10, 2024

thanks, but is ninja a must?

@chinwobble
Copy link
Contributor Author

chinwobble commented Dec 10, 2024

thanks, but is ninja a must?

I understand you want to keep dependencies to a minimum.
I tried to remove ninja but it wasn't easy and caused some features like multiple build configuration which we would have to add back by writing our own CMake content.
I think if someone can install a c++ compiler they can easily install ninja. On Ubuntu its less than 1 MB.

@sfchen
Copy link
Member

sfchen commented Dec 11, 2024

okay, can you add a commit to copy builds/ninja-multi-vcpkg/Release/fastplong to the path of project ./, after build is completed? Since biological users may not know where to find the executable.

@sfchen sfchen merged commit a044607 into OpenGene:main Dec 12, 2024
3 checks passed
@sfchen
Copy link
Member

sfchen commented Dec 12, 2024

merge it first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants