Fix for getting size of unallocated array #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the code uses size(Ary) on an Ary that is not necessarily allocated. Now it is allocated to size 0 if there are no continuous states, which should fix the issues with using the size() function.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This fixes a runtime issue that could occur with some compilers. The code was asking for the size of an array that was not allocated, which some compilers define as 0, but is an undefined operation on others.
Related issue, if one exists
#620
Impacted areas of the software
Linearization with AeroDyn (without continuous states), using non-Windows and/or non-Intel setup.
Test results, if applicable
This shouldn't change any test results.